search

andrewhwood / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

NuPatch has much wrongness #175

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1) I've started to fix this already (see 
http://code.google.com/r/ardent-embic/source/detail?r=e87acf8aae7c5805b90cb4d2fe
eb7844daad0b49&name=default), but "not writing trim curves" is not supported.

2) Related to point 1, the trimcurve-handling code in ONuPatchSchema::set() 
incorrectly uses SetPropUsePrevIfNull() for scalar properties.  There needs to 
be a sentinel value for "not set", as with SubDs.

This is currently blocking our internal dev effort.

Original issue reported on code.google.com by ard...@gmail.com on 15 Jun 2011 at 7:00

GoogleCodeExporter commented 9 years ago 
Some (maybe all) of this may have already been done in my dev clone, you might 
also use that for a head start.

Original comment by miller.lucas on 15 Jun 2011 at 7:17

GoogleCodeExporter commented 9 years ago 
OK, I think this is done:

http://code.google.com/r/ardent-embic/source/detail?r=088c9af169719fdbe4e3285229
53b1364ef536fb

http://code.google.com/r/ardent-embic/source/detail?r=439a2fb1b615eae492582e4195
1b5de5479ac4d9

Original comment by ard...@gmail.com on 16 Jun 2011 at 6:43

GoogleCodeExporter commented 9 years ago 
Is ABC_GEOM_NUPATCH_NULL_INT_VALUE really necessary?
For the int32_t values in NuPatch, 0 seems like a good empty value.

Original comment by miller.lucas on 16 Jun 2011 at 7:21

GoogleCodeExporter commented 9 years ago 
Only thing left is to add optional w and support it in the plugins.

Original comment by miller.lucas on 23 Jun 2011 at 9:38

GoogleCodeExporter commented 9 years ago 
w support is already an issue in this ticket:
http://code.google.com/p/alembic/issues/detail?id=176

Original comment by miller.lucas on 28 Jun 2011 at 9:13