andrewhwood / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

getPositions() and all methods in Geom classes that return a Property should be fixed, as in getPositionsProperty #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Inside of IPolyMesh.h there are two identically named getPositions  () methods.
There is a getPositions () method on the inner class Sample, and then also on 
IPolyMeshSchema.
This is confusing.  For performance reasons (especially with large meshes) 
efficeint read code will want to access the position property directly without 
having to access an entire Sample (which is much heavier, even when properties 
of the mesh are constant).
This method name is confusing. 
Also, for anyone reading the code in AbcGeom itself we should really fix the 
member name, because we have both m_positions and m_positions and one is the 
property and one is the ArraySample

Original issue reported on code.google.com by ble...@gmail.com on 8 Jul 2011 at 12:56

GoogleCodeExporter commented 9 years ago
According to the meeting today, we will be doing this for 1.0.

Original comment by scottmmo...@gmail.com on 11 Jul 2011 at 11:11

GoogleCodeExporter commented 9 years ago

Original comment by ard...@gmail.com on 15 Jul 2011 at 10:18

GoogleCodeExporter commented 9 years ago
Meeting with the team right now - team noted issue was closed.

Please comment or edit ticket if needed.

Thanks, Scott

Original comment by scottmmo...@gmail.com on 20 Jul 2011 at 10:07