search

andrewhwood / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

SimpleAbcViewer not respecting IXformSchema::getInheritsXforms() #215

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Load the example file attached, the pencil should line up with the curves
and the cube, intead it's offset.

Original issue reported on code.google.com by miller.lucas on 25 Aug 2011 at 7:08

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by ble...@gmail.com on 25 Aug 2011 at 10:51

GoogleCodeExporter commented 9 years ago

Original comment by ble...@gmail.com on 26 Aug 2011 at 11:14

GoogleCodeExporter commented 9 years ago

Original comment by ble...@gmail.com on 26 Aug 2011 at 11:55

GoogleCodeExporter commented 9 years ago 
In this abc file we have a pencil and a cube with a stack of curves above it. 
The pencil and the cube + stack are in different locations. 

I'm examining the attached pencil_test.abc and I don't seem to find any Xform 
objects that have inheritsXforms set to false. Should there be? All the 
inheritisXforms values look to be set to be true.

Original comment by ble...@gmail.com on 29 Aug 2011 at 9:29

GoogleCodeExporter commented 9 years ago 
Based on who did the estimates, etc., I am assuming this is going to Brian L.

Original comment by scottmmo...@gmail.com on 29 Aug 2011 at 11:03

GoogleCodeExporter commented 9 years ago 
pencil1A/trs_master/trs_shot/trs_aux/model

AND

pencil1A/trs_master/trs_shot/trs_aux/rig

both have inheritsXforms set to false.

Original comment by miller.lucas on 30 Aug 2011 at 5:35

GoogleCodeExporter commented 9 years ago 
Whoops,
pencil1A/trs_master/trs_shot/trs_aux/rig is set to true,

pencil1A/trs_master/trs_shot/trs_aux/rig/misc  has it set to false.

Original comment by miller.lucas on 30 Aug 2011 at 5:36

GoogleCodeExporter commented 9 years ago 
Looks like I'm taking this.

Original comment by miller.lucas on 7 Sep 2011 at 4:52

GoogleCodeExporter commented 9 years ago 
Thanks Lucas. :) Sorry for getting to the ticket late with Kudos.

Original comment by scottmmo...@gmail.com on 9 Sep 2011 at 10:19

GoogleCodeExporter commented 9 years ago 
It's not gonna be a simple fix, as hierarchy is currently traversed from the 
top to the bottom, which isn't a problem for the drawing, but is a problem for 
gathering the bounds when inheritsXform is false for one of the descendant 
Xforms.

Punting this to 1.1 and unassigning for now.

Original comment by miller.lucas on 9 Sep 2011 at 11:42

GoogleCodeExporter commented 9 years ago 
Found a way to do this without changing the traversal.

Fix is here:

http://code.google.com/r/millerlucas-dev/source/detail?r=7223bc4b389110f6becb9c1
5e0c8bc15d1050383

Original comment by miller.lucas on 21 Sep 2011 at 7:34

GoogleCodeExporter commented 9 years ago

Original comment by miller.lucas on 15 Oct 2011 at 12:30