search

andrewhwood / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

When reading, calls to I<type>GeomParam are matching to properties that aren't actually geom params. #245

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In a test asset several normal properties were added to the compound property 
used for storing arbitrary geom params.  On read, the call to matches () for 
geom params was returning true for these properties.

A unit test to deomnstrate the problem (and then the fix) will be coming 
tomorrow.

Original issue reported on code.google.com by ble...@gmail.com on 25 Oct 2011 at 1:08

GoogleCodeExporter commented 9 years ago 
This has been fixed in my trunk.

The matches on just the MetaData has just been removed as you need to match on 
the PropertyHeader to have access to the DataType AND extent.

Also, it's okay if the GeomParam matches an ArrayProperty if they have the same 
type and extent even if it wasn't marked with scope, since the lack of scope is 
now considered constant.  GeomParam matches will NOT match a ScalarProperty.

Original comment by miller.lucas on 23 May 2012 at 1:07

GoogleCodeExporter commented 9 years ago 
Fixed in the new released 1.1

Original comment by miller.lucas on 2 Aug 2012 at 11:11