andrewiggins / tachometer-reporter-action

Report the results of Polymer/tachometer in a comment for PRs
MIT License
23 stars 4 forks source link

Fix mixed tabs and spaces in yaml example in README #50

Closed marvinhagemeister closed 2 years ago

marvinhagemeister commented 3 years ago

By default GitHub shows a red box indicating a parser error when yaml is indented with tabs. This is in line with the YAML Specification, which lists that tabs are invalid if used for indentation.

This PR resolves that error by converting the tabs to spaces.

github-actions[bot] commented 3 years ago

📊 Tachometer Benchmark Results

Summary

duration

  • test_bench: slower ❌ 24% - 28% (34.69ms - 39.26ms)
    base-framework vs fast-framework Customize summary
  • test_bench_2: slower ❌ 9% - 17% (0.32ms - 0.59ms)
    base-framework vs fast-framework Customize summary

window.usedJSHeapSize

  • test_bench: slower ❌ 36% - 37% (0.95ms - 0.95ms)
    base-framework vs fast-framework Customize summary
  • test_bench_2: faster ✔ 8% - 8% (0.09ms - 0.09ms)
    base-framework vs fast-framework Customize summary

Results

test_bench

duration

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework137.71ms - 141.73ms-faster ✔
20% - 22%
34.69ms - 39.26ms
faster ✔
14% - 18%
23.26ms - 31.06ms
base-framework175.60ms - 177.79msslower ❌
24% - 28%
34.69ms - 39.26ms
-slower ❌
4% - 8%
6.30ms - 13.34ms
local-framework163.53ms - 170.22msslower ❌
16% - 22%
23.26ms - 31.06ms
faster ✔
4% - 8%
6.30ms - 13.34ms
-

window.usedJSHeapSize

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework2.61ms - 2.61ms-faster ✔
27% - 27%
0.95ms - 0.95ms
faster ✔
62% - 62%
4.20ms - 4.21ms
base-framework3.56ms - 3.57msslower ❌
36% - 37%
0.95ms - 0.95ms
-faster ✔
48% - 48%
3.25ms - 3.26ms
local-framework6.81ms - 6.82msslower ❌
161% - 161%
4.20ms - 4.21ms
slower ❌
91% - 91%
3.25ms - 3.26ms
-
test_bench_2

duration

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework3.46ms - 3.70ms-faster ✔
8% - 15%
0.32ms - 0.59ms
slower ❌
34% - 54%
0.89ms - 1.28ms
base-framework3.98ms - 4.10msslower ❌
9% - 17%
0.32ms - 0.59ms
-slower ❌
52% - 72%
1.38ms - 1.71ms
local-framework2.34ms - 2.65msfaster ✔
26% - 35%
0.89ms - 1.28ms
faster ✔
34% - 42%
1.38ms - 1.71ms
-

window.usedJSHeapSize

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework1.09ms - 1.09ms-slower ❌
9% - 9%
0.09ms - 0.09ms
slower ❌
11% - 11%
0.11ms - 0.11ms
base-framework1.00ms - 1.00msfaster ✔
8% - 8%
0.09ms - 0.09ms
-slower ❌
2% - 2%
0.02ms - 0.02ms
local-framework0.98ms - 0.98msfaster ✔
10% - 10%
0.11ms - 0.11ms
faster ✔
2% - 2%
0.02ms - 0.02ms
-

tachometer-reporter-action v2 for PR Artifacts For Forks Flow