search

andrewjw / i75

Wrapper around Pimoroni's Interstate75 library to allow for local testing
GNU General Public License v3.0
2 stars 2 forks source link

fix 64x64 hardcoded #99

Closed danjenkins closed 1 day ago

danjenkins commented 2 days ago

use the height and width set as part of setting up the display, not hardcoded to 64x64

closes #97

andrewjw commented 2 days ago

This change looks good to me. I'm slightly concerned about the performance hit of calling get_bounds every time a pixel is drawn, might be better to cache the width and height as member variables in the constructor?

Can you edit the commit message to be in Angular format? Something like fix: Remove hardcoding for 64x64 screen size would be good. (git commit --amend will let you change the message of the existing commit.)

danjenkins commented 1 day ago

Updated @andrewjw

andrewjw commented 1 day ago

Thanks so much for this change Dan! This has been released as 1.8.3.