search

andrewkroh / gvm

Go Version Manager (written in Go for cross-platform usability)
Apache License 2.0
186 stars 24 forks source link

Fall back to source install only when binary package does not exist (HTTP 404) #30

Closed andrewkroh closed 3 years ago

andrewkroh commented 3 years ago

When the install from a binary package fails it falls back to installing from source. I think the only case where the fallback should occur is when the server responds with a 404 that no binary package exists. Otherwise it's falling back on various IO or permissions errors like

[2020-11-24T13:07:55.561Z] time="2020-11-24T13:07:54Z" level=warning msg="Failed to install Go from binary package. Trying to install from source." error="rename C:\\Users\\jenkins\\.gvm\\versions\\go1.14.7.windows.amd64.tmp\\go C:\\Users\\jenkins\\.gvm\\versions\\go1.14.7.windows.amd64: Access is denied." version=1.14.7