search

andrewkroh / gvm

Go Version Manager (written in Go for cross-platform usability)
Apache License 2.0
186 stars 24 forks source link

Add wait between retries when there are download errors #65

Closed dliappis closed 1 year ago

dliappis commented 1 year ago

Currently gvm makes three attempts at retrying a failed download, but it doesn't wait in between.

This commit adds rudimentary wait time between download attempts. It also increases the number of retries to 5.

In a future refactoring we could use go-retryablehttp^1 (we'd still need to guard for errors with io.Copy) but keeping the improvement short for now, hoping to reduce download related CI failures.

dliappis commented 1 year ago

LGTM. Can you please add an entry to CHANGELOG.md.

Thanks for the quick review! Added in d9cfa890e1e5e28eca254fa6376e8fc296283b09

andrewkroh commented 1 year ago

Released in https://github.com/andrewkroh/gvm/releases/tag/v0.5.2