Overhaul to execute at form submission (#2)

andrewlimaza / caldera-forms-anti-spam

Caldera Forms Anti Spam WordPress plugin. This adds Google's reCAPTCHA field to your Caldera Form.

https://wordpress.org/plugins/cf-anti-spam/

25 stars 16 forks source link

Overhaul to execute at form submission (#2) #21

Closed ecaron closed 4 years ago

ecaron commented 4 years ago

Core changes:

Execution only happens at form submission
Removed older Caldera code they no longer have in mainline
Made it clearer when using v2 or v3
Passing WordPress CodeSniffer rules
Script now injects at footer of page

ecaron commented 4 years ago

@andrewlimaza, anything I can do to help make this easier to review?

andrewlimaza commented 4 years ago

Thanks for submitting this PR @ecaron. I am going to work through it as soon as I can and get it merged in. I took a quick look and it looks good to me so far. :)

andrewlimaza commented 4 years ago

I've created a test branch and merged this in to run some more tests before uploading this to SVN. It should be relatively soon! I'll definitely include you in the changelog for recognition of this change. Thank you so much for contributing to Caldera Forms Anti Spam! :)

ecaron commented 4 years ago

@andrewlimaza, any progress in merging this into master and tagging it v0.4?