Closed SeanFarrow closed 5 years ago
andrewlock
commented
5 years ago Nice idea! It would be best if we could pin any 2.x (for now) global.json rather than necessarily having to be 2.2 - when you don't have the right SDK installed you always got horrible unclear error messages (not sure if that's changed) so would be good to avoid that. I'm fairly sure you can have wildcards in the SDK name
SeanFarrow
commented
5 years ago It’s something I’d need to look in to but will do that over the next day or so.
From: Andrew Lock notifications@github.com Sent: 29 April 2019 09:11 To: andrewlock/PwnedPasswords PwnedPasswords@noreply.github.com Cc: Sean Farrow sean.farrow@seanfarrow.co.uk; Author author@noreply.github.com Subject: Re: [andrewlock/PwnedPasswords] Add a global.json file so that any new projects use the released .Net sdk (#11)
Nice idea! It would be best if we could pin any 2.x (for now) global.json rather than necessarily having to be 2.2 - when you don't have the right SDK installed you always got horrible unclear error messages (not sure if that's changed) so would be good to avoid that. I'm fairly sure you can have wildcards in the SDK name
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/andrewlock/PwnedPasswords/issues/11#issuecomment-487486472, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AALDK7QAU773HGPHGSVQX2DPS2URFANCNFSM4HJBEN7Q.
SeanFarrow
commented
5 years ago According to here A full version number is required.
I'm therefore proposing we support .net sdk 2.1.603.
I don't think we are using any .Net 2.2 features from what I've seen, but feel free to correct me.
It would probably be good to add a global.json file so that the latest released .net sdk is used and not any preview anyone cloning the repo might have installed.