@SeanFarrow FYI, I updated a few things - I assume the main typo you were referring to was Pwned Passports ? 😉
I can't seem to find where this is used in the sample app though
The client is added implicitly when you call the validator, if it hasn't already been added. Good call on showing the usage with Polly though, so I've added that to the sample.
Also, I updated the Validator so it doesn't throw if there's an exception calling the endpoint - I think we should be conservative in that case, and assume that the password is ok, otherwise noone would ever be able to create a password if the API is down!
I'll merge this shortly, and work on updating the readme.
I'm also thinking I should rename the repo to be PwnedPasswords instead of HaveIBeenPwnedValidator. I went back and forth about PwnedPasswords vs HaveIBeenPwned in the project, but seeing as the client only uses that one part of the API (rather than the full data-breach API) it seemed best.
@SeanFarrow FYI, I updated a few things - I assume the main typo you were referring to was Pwned Passports ? 😉
The client is added implicitly when you call the validator, if it hasn't already been added. Good call on showing the usage with Polly though, so I've added that to the sample.
Also, I updated the Validator so it doesn't throw if there's an exception calling the endpoint - I think we should be conservative in that case, and assume that the password is ok, otherwise noone would ever be able to create a password if the API is down!
I'll merge this shortly, and work on updating the readme.
I'm also thinking I should rename the repo to be PwnedPasswords instead of HaveIBeenPwnedValidator. I went back and forth about PwnedPasswords vs HaveIBeenPwned in the project, but seeing as the client only uses that one part of the API (rather than the full data-breach API) it seemed best.