search

andrewlock / PwnedPasswords

An ASP.NET Core Identity validator that checks for PwnedPasswords
MIT License
103 stars 12 forks source link

Allow setting frequency threshold for breached passwords #8

Closed darshanrampatel closed 5 years ago

darshanrampatel commented 5 years ago

It would be useful if there was an option to choose the frequency of how many times a password was breached (e.g. only reject passwords that have been breached > 20 times).

https://github.com/andrewlock/PwnedPasswords/blob/a2eb87dea7c046f86bdf5f2fb730a0a0ec2a022d/src/PwnedPasswords.Client/PwnedPasswordsClient.cs#L45

andrewlock commented 5 years ago

Thanks, sounds like a good idea to me🙂 I'll try and get this implemented today.

andrewlock commented 5 years ago

I have implemented the behaviour in a PR #9 - I'd be interested if that looks OK to you before I merge it and push a new package🙂

darshanrampatel commented 5 years ago

I have had a look and it looks great - thanks for getting to this so quickly!

Only thought I had was it might be worth updating the readme to show the option.

andrewlock commented 5 years ago

Good point, thanks! I'll get that updated and merged soon 🙂

darshanrampatel commented 5 years ago

Thanks!

andrewlock commented 5 years ago

No problem, thanks for the suggestion 🙂