Why not use ISerializable instead of using a JSonConverter

andrewlock / StronglyTypedId

A Rosyln-powered generator for strongly-typed IDs

MIT License

1.52k stars 79 forks source link

Closed kYann closed 9 months ago

kYann commented 5 years ago

Hi,

Nice project ! Why not use the ISerialiazable interface avaible since .Net Standard 2.0 to allow json conversion without the need of a reference on JSonConverter ? https://www.newtonsoft.com/json/help/html/SerializationGuide.htm#ISerializable

Maybe it could be an option ?

andrewlock commented 5 years ago

Thanks! To be honest, I rarely use ISerializable. It's just such an ugly API 😉

It could be an option, sure, but I don't have a great inclination to add it at the moment. PRs always welcome 🙂

andrewlock commented 9 months ago

If this is something you still want you can now do it with the work in #117 🙂