search

andrewlock / StronglyTypedId

A Rosyln-powered generator for strongly-typed IDs
MIT License
1.5k stars 78 forks source link

StronglyTypedId 1.0.0-beta7 GeneratedCodeAttribute still refers to "1.0.0-beta6". #132

Closed brianwestfall1971 closed 4 months ago

brianwestfall1971 commented 4 months ago

During the course of debugging an issue ,I discovered that with 1.0.0-beta7 installed, source generated code contains this annotation: [global::System.CodeDom.Compiler.GeneratedCodeAttribute("StronglyTypedId", "1.0.0-beta6")].

The same behaviour is observed with StronglyTypedId.Templates with an annotation like so: [assembly: StronglyTypedIdDefaults(Template.Int, "guid-dapper")]

I'm not sure if this is related to me having problems with getting the Dapper templates to work or not.

brianwestfall1971 commented 4 months ago

Correction to the second annotation, it should be: [assembly: StronglyTypedIdDefaults(Template.Int, "int-dapper")].

andrewlock commented 4 months ago

Yeah, that was a typo, it was fixed in this PR but I haven't done another release yet (which would just bump this string, which doesn't seem worth it!)

AFAIK, that value isn't actually used for anything, so I don't think it really matters?

brianwestfall1971 commented 4 months ago

I just wanted to check because I know the configuration was a breaking change from beta6 to beta7 and was uncertain if the beta7 logic was actually creating the partial code.

Thanks.

andrewlock commented 4 months ago

Makes sense, sorry for the confusion!