NxSoftware
commented
2 years ago +1 for this but I'd propose an enum that allows for:
- the current behaviour of generating a public constructor (probably the default)
- generate a
privateconstructor (with the implementation otherwise as-is) - completely disable constructor generation
My idea behind a private constructor would allow for static factory method(s) to be used for creating instances using a pattern similar to Guid.TryParse
Example
[StronglyTypedId(constructor: StronglyTypedIdConstructor.Private)]
partial struct MyStrongString
{
public static bool TryParse(string value, out MyStrongString? result)
{
if (CanParse) // Pseudo-code
{
result = new MyStrongString(value);
return true;
}
result = null;
return false;
}
}
andrewlock
My proposal is to add a boolean switch on the
[StronglyTypedId]attribute that would indicate if the generator should generate the default constructor that accepts theBackingTypevalue.That way someone could provide his own custom constructor that accepts the
BackingTypeand allow for further customisation of the finalValueproperty.I found myself in need of this actually only on the
stringtype so far since I wanted to do some extra work to some ids.If this sounds okay with you I would love to sit and try to implement it myself when I have some time 😸