search

andrewmcgivery / ionic-ion-autoListDivider

Gives a set of directives for automatically adding in list dividers for an ng-repeat. (Works for Alphabetical or by Categories)
75 stars 21 forks source link

Pull to Refresh duplicates item-dividers #5

Open jameslegue opened 9 years ago

jameslegue commented 9 years ago

Pulled this directive in, and when doing a pull to refresh on this directive with a list, it seems to duplicate the item-dividers that were initially inserted as dupes at the bottom of the list.

scotthooker commented 9 years ago

It doesn't duplicate them it just leaves the old headers in.

labcd commented 9 years ago

I'm also having this issue. Any idea on how to solve this?

Taylorsuk commented 9 years ago

No - I considered trying this: http://forum.ionicframework.com/t/generating-list-with-dividers-dynamically/341/5 but I am not keen on it.

labcd commented 9 years ago

Thanks. I do not like that approach too. Gonna keep searching for a better one.

MrPro100 commented 9 years ago

someone has solved this bug?

junerockwell commented 8 years ago

+1

anonrig commented 8 years ago

+1

zvineyard commented 8 years ago

I fixed this bug, but to make sure I was only removing the headers on a single view, I had to pass in another attribute from the ng-repeat tag. I've push those changes to a fork (with updates to the README) but I'm hesitant to make a pull-request because it is a pretty substantial change. You can see my work here: https://github.com/zvineyard/ionic-ion-autoListDivider

Should I pull-request this?

Ontarion commented 8 years ago

fix from zvineyard works great. thank you)