Closed AndreCI closed 4 months ago
Hey @AndreCI :)
Appreciate you taking the time to open this PR. 😃
I just released a pretty big update of this plugin that would render your PR unmergeable at this point, so you'll likely need to go back to the drawing board.
Other feedback I'd have before I could consider this contribution:
setTimeout
should generally be avoided in the way you're using it as it created an unnecessary race conditionHappy to consider this on a new PR against the up-to-date code base and those feedback items addressed or you can open an issue and I may get to it at some point but in either case, closing this PR for now.
Motivation: I enjoy listening to LoFi at x1.25 :)