Use upper-bound correctly in parse-number fn

andrewmcveigh / cljs-time

A clj-time inspired date library for clojurescript.

342 stars 57 forks source link

Use upper-bound correctly in parse-number fn #125

Open dvdreddy opened 6 years ago

dvdreddy commented 6 years ago

Lower / Upper bound was not being correctly enforced when trying to read a number
Also force the default radix to be 10 to avoid irregular behavior of the parse fn

Fixes #124

danielcompton commented 6 years ago

Would it be good to add some tests exercising this change?

dvdreddy commented 6 years ago

Just for the parse-number I can surely add,

But for overall parsing I tried to come up with a case which fails the formatting for date-time, I came up short mainly because the current code works fine due to the separators.

danielcompton commented 5 years ago

If you can write some tests for parse-number that fail under the old implementation, that would be great.

But for overall parsing I tried to come up with a case which fails the formatting for date-time, I came up short mainly because the current code works fine due to the separators.

Can you explain this a little more? I think I might know what you mean, but it'd be good to have an example to make sure we're on the same page.