add locale support for unparse using a formatter

andrewmcveigh / cljs-time

A clj-time inspired date library for clojurescript.

342 stars 57 forks source link

add locale support for unparse using a formatter #77

Closed CarlosSam closed 7 years ago

CarlosSam commented 8 years ago

I developed support for localized formatter using the with-locale function.

andrewmcveigh commented 7 years ago

Hey,

Thanks very much for this. I've a couple comments above. Mainly about the use of with-redefs. Personally I don't think using with-redefs (or really rebinding vars in general) is suitable for library code. It could lead to really unexpected bugs for users. Is there a way to do this with a more functional approach?

andrewmcveigh commented 7 years ago

See #85 for a fuller implementation.