search

andrewmcveigh / cljs-time

A clj-time inspired date library for clojurescript.
342 stars 57 forks source link

Promote the macro file(s) to .cljc for self-host compatibility #87

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

Hello folks!

This is the first project I tried in lumo that worked at the first attempt, thanks! Many many thanks! I have created this PR to be thorough and change the only macro file that needs conversion.

Macros are tough, in general and especially in self-hosted ClojureScript :smile:

The tests are passing as well:

;; ======================================================================
;; Testing with Node:

Testing cljs-time.core-test

Testing cljs-time.local-test

Testing cljs-time.format-test

Testing cljs-time.predicates-test

Testing cljs-time.coerce-test

Testing cljs-time.periodic-test

Testing cljs-time.extend-test

Testing cljs-time.dce-compile-test

Ran 110 tests containing 531 assertions.
0 failures, 0 errors.
andrewmcveigh commented 7 years ago

Awesome, merged. Thanks!

arichiardi commented 7 years ago

@andrewmcveigh Thank you! Is it already in some SNAPSHOT release by any chance :angel: ?

andrewmcveigh commented 7 years ago

Hey,

Yeah, I've just pushed a 0.5.0-SNAPSHOT.