search

andrewnguonly / Lumos

A RAG LLM co-pilot for browsing the web, powered by local LLMs
MIT License
1.42k stars 102 forks source link

Hotkeys for Windows PC #188

Closed ColumbusAI closed 3 months ago

ColumbusAI commented 3 months ago

How can I modify the hotkeys e.g. 'cmd + b' that are for Mac to a Windows PC?

andrewnguonly commented 3 months ago

Thanks for raising this issue @ColumbusAI. I created a PR to check the alt key in the case for Windows PC: https://github.com/andrewnguonly/Lumos/pull/189.

I don't actually have a Windows PC to test this with. Are you able to pull my branch and verify the changes?

ColumbusAI commented 3 months ago

yes absolutely! will do and report back shortly

ColumbusAI commented 3 months ago

ran into a couple of errors loading unpacked, first being the tests folder I renamed to tests removing underscores and that seemed to solve that but then the background.js is missing and couldn't find in the source?

tests background

andrewnguonly commented 3 months ago

@ColumbusAI, can you try this:

  1. Run the command npm run build to build the extension. You'll need to have npm installed.
  2. A new dist folder will be created.
  3. Select the dist folder instead of the root Lumos directory when loading the extension.
ColumbusAI commented 3 months ago

works perfectly! I tried all hotkey combinations that call for the alt vs cmd and they worked. 👍

Thinking about hotkeys here...could you please add a tooltip or some other visual indicator that can call out the various hotkeys that are available when the Lumos window is open?

currently I need to have the lumos repo open to recall the hotkeys and having a help menu or such integrated into the workflow would help to drive adoption of hotkeys for usability

Screenshot 2024-08-25 123007

andrewnguonly commented 3 months ago

Thinking about hotkeys here...could you please add a tooltip or some other visual indicator that can call out the various hotkeys that are available when the Lumos window is open?

Fair feedback. I originally had tool tips for each button, but I felt like they were crowding the UI. I can bring them back and see how it feels. I'll do this as part of the open PR.

ColumbusAI commented 3 months ago

thank you!!

Thinking about hotkeys here...could you please add a tooltip or some other visual indicator that can call out the various hotkeys that are available when the Lumos window is open?

Fair feedback. I originally had tool tips for each button, but I felt like they were crowding the UI. I can bring them back and see how it feels. I'll do this as part of the open PR.