search

andrewphorn / ClassiCube-Client

The applet used for classicube.net
34 stars 19 forks source link

Fixed loading-screen flicker in multiplayer. #287

Closed mstefarov closed 10 years ago

mstefarov commented 10 years ago

Flicker was caused because ProgressBarDisplay class was meant to take over rendering. In multiplayer, it ran in the middle of the main render loop instead -- so both the map and the progress bar kept rendering over each other. Now, the network code inside Minecraft.tick() will keep reading from the network non-stop from the moment LEVEL_INIT is received and until the whole map is loaded. Maps actually load slightly faster now!

Jonty800 commented 10 years ago

Good job, was looking for this solution quite some time ago On 21 Oct 2014 19:15, "Matvei Stefarov" notifications@github.com wrote:

Flicker was caused because ProgressBarDisplay class was meant to take over rendering. In multiplayer, it ran in the middle of the main render loop instead -- so both the map and the progress bar kept rendering over each other. Now, the network code inside Minecraft.tick() will keep reading from the network non-stop from the moment LEVEL_INIT is received and until the

whole map is loaded. Maps actually load slightly faster now!

You can merge this Pull Request by running

git pull https://github.com/fragmer/ClassiCube-Client master

Or view, comment on, or merge it at:

https://github.com/andrewphorn/ClassiCube-Client/pull/287 Commit Summary

  • Attempting a fix for loading-screen flicker. Singleplayer is currently broken (no idea why).
  • Fixed single-player flicker caused by previous commit.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/andrewphorn/ClassiCube-Client/pull/287.