New Loading behavior breaks function

[voidpublic]

So basically with something in the new update /ref is no longer working, meaning its crashing the client completely

What it basically does is it reloads everything for the user (so sends MOTD) so i suppose that is the issue.

[123DMWM]

That sounds like a server problem. What server software is this on? Please follow This quide to help us.

[mstefarov]

I'll take a look. I've noticed that WoM-style extensions (via &cfg=... in motd) stopped working on my server too. Could be related to your problem.

[voidpublic]

Well i am based on MCForge but use my own distri, i mostly code it myself xwom / wom doesnt seem to have a problem:

    public void SendUserMOTD()
    {
        byte[] buffer = new byte[130];
        buffer[0] = Server.version;
        if (UsingWom && (level.textures.enabled || level.motd == "texture") && group.Permission >= level.textures.LowestRank.Permission) { StringFormat(Server.name, 64).CopyTo(buffer, 1); StringFormat("&0cfg=" + Server.IP + ":" + Server.port + "/" + level.name, 64).CopyTo(buffer, 65); }
        if (level.motd == "ignore")
        {
            StringFormat(Server.name, 64).CopyTo(buffer, 1);
            if (!String.IsNullOrEmpty(group.MOTD)) StringFormat(group.MOTD, 64).CopyTo(buffer, 65);
            else StringFormat(Server.motd, 64).CopyTo(buffer, 65);
        }
        else StringFormat(level.motd, 128).CopyTo(buffer, 1);
        //if (Block.canPlace(this.group.Permission, Block.blackrock))
            if (this.referee)
            buffer[129] = 100;
        else
            buffer[129] = 0;
        SendRaw(0, buffer);
    }

This after a player is already connected makes them crash.

I ruled out the motd, so its the SendRaw giving the Client problems

[mstefarov]

Reproduced. I'll be working on a fix. Thanks for reporting!

[voidpublic]

This should be included asap as this is degrading functionality

[mstefarov]

Almost done with all the bugfixes. Patch soon!

[voidpublic]

Appearently the patch didnt fix the issue if it was included in the last update?

[123DMWM]

Got a server up for testing?

[mstefarov]

WoM configs do load, but not all functionality is restored yet.

These parameters work:

• server.name
• server.detail
• detail.user
• server.sendwomid

These do not [yet]:

• environment.cloud
• environment.fog
• environment.sky
• environment.level
• environment.edge
• environment.side
• environment.terrain

A separate issue (#305) has been created to track support for "environment" parameters.

[mstefarov]

Also, at no point did I run into client crashes while working on this. Even when client did not read configs, it did not crash. If you ARE experiencing a crash, you'll have to give us more details (e.g. what config you are sending, and when are you sending it).

[voidpublic]

https://gist.github.com/cec1266a92655909ac1d Debug mode doesnt really give me much, if you need a server where to reproduce, i can offer that, got any IM like skype? MOTD: Play fair, have fun -hax +ophax

[andrewphorn]

You can contact us on IRC, we're always available there.