search

andrewplummer / Sugar

A Javascript library for working with native objects.
https://sugarjs.com/
MIT License
4.53k stars 306 forks source link

Support for Turkish and Norwegian locales #530

Closed smurali31 closed 7 years ago

smurali31 commented 8 years ago

Is support for these two locales coming soon? We have a product that needs to support these locales.

andrewplummer commented 8 years ago

Support for these two locales isn't planned simply because I don't have access to speakers of these locales. If you could procure them we can easily get them in by next release, however. Copying the test and locale files should be quite straight forward.

We already have Swedish so Norwegian shouldn't be too difficult. Turkish sounds like it may be hard however (afaik it's rather unique).

ermouth commented 8 years ago

@johs May be you could help with it? Date format templates are quite straightforward and short, for example Swedish https://github.com/andrewplummer/Sugar/blob/master/lib/locales/sv.js

johs commented 8 years ago

Ok, modified the Danish Johs

On 14. jan. 2016, at 19.34, ermouth notifications@github.com wrote:

@johs https://github.com/johs May be you could help with it? Date format templates are quite straightforward and short, for example Swedish https://github.com/andrewplummer/Sugar/blob/master/lib/locales/sv.js https://github.com/andrewplummer/Sugar/blob/master/lib/locales/sv.js — Reply to this email directly or view it on GitHub https://github.com/andrewplummer/Sugar/issues/530#issuecomment-171732842.

andrewplummer commented 8 years ago

Looking good! ... I don't suppose I can convince you to add tests as well? :D I got it started with this commit: f8bd936.

andrewplummer commented 8 years ago

Now anyone know any Turkish developers?? :)

johs commented 8 years ago

Sorry Andrew, Sugar is a dependancy on ermouth*s systems that I am using, so I haven’t programmed for it. johs:)

On 15 Jan 2016, at 15:56, Andrew Plummer notifications@github.com wrote:

Looking good! ... I don't suppose I can convince you to add tests as well?

andrewplummer commented 8 years ago

No programming required! Basically have a look at the file I committed. There's english at the end. Just replace the Swedish phrases with Norwegian that matches the english. Don't worry about running anything. As long as the phrases are correct I will make the tests pass!

andrewplummer commented 8 years ago

No tests for me? :(

Even text format would be ok... I just need the linguistic skills....

cevatkerim commented 8 years ago

@andrewplummer I'll do the Turkish one. Is there a reference file I can follow?

andrewplummer commented 8 years ago

Hi! Thanks so much! You check any of the locale files in the new branch, and also English in date.js. Lastly, I've updated the readme as well.

As I understand Turkish is a bit on it's own linguistically (at least compared to major world languages) so I don't know if theres a good one to branch from but English has the most examples and Russian or Polish have examples of functions being used due to some tricky grammar.