andrewplummer / Sugar

A Javascript library for working with native objects.
https://sugarjs.com/
MIT License
4.53k stars 305 forks source link

Do not fall back to native date parsing #638

Open andrewplummer opened 5 years ago

andrewplummer commented 5 years ago

Falling back was at one point a safety but the Sugar library has matured and handles many if not all native formats. Falling back now makes the library vulnerable to browser updates and inconsistencies.

This issue tangentially relates to the controversy around extending prototypes. The goal here is to close Sugar off from all vectors of breakage caused by changes in the environment. Prototype extension has done this, but falling back to native date parsing is still exposing us here.