search

andrewprock / pokerstove

poker evaluation and enumeration software
BSD 3-Clause "New" or "Revised" License
806 stars 350 forks source link

Remove finding the local gtest #75

Closed lucasmitrak closed 1 year ago

lucasmitrak commented 3 years ago

This patch was written against v1.0 of andrewprock's pokerstove: https://github.com/andrewprock/pokerstove This patch fixes two upstream bugs: #73 and #74 available here: https://github.com/andrewprock/pokerstove/issues/73 https://github.com/andrewprock/pokerstove/issues/74

Since cmake cannot detect the local gtest, the system's gtest is required to compile correctly. Without this patch, cmake will fail to find the local gtest during the cmake configure phase. After this patch, cmake will not search for the local gtest but use the system gtest gtest was added to the requirements listed in the README.md gtest was removed from the source code and the cmake file

This patch was written by Lucas Mitrak and will be made available upstream. This patch was tested locally and in a docker image created by ebuildtester

lucasmitrak commented 3 years ago

Let me know what reservations you have about this PR.

andrewprock commented 1 year ago

Unfortunately, this requires pulling an unversioned gtest from the internet. As this code should not break due to upstream dependencies, relying on Google to maintain legacy versions over a period of years is not sustainable, thus the vendor'd version in the repo.