andrewrk / groovebasin

Music player server with a web-based user interface.
MIT License
1.9k stars 119 forks source link

sometimes clicking the stream button causes double events #373

Open thejoshwolfe opened 9 years ago

thejoshwolfe commented 9 years ago

I've got the page in some kind of state (no js errors) where clicking the stream button toggles between 0 and 2 streamers, and the events tab is showing this:

josh | started streaming
* | anonymous user started streaming
* | anonymous user stopped streaming
josh | stopped streaming
josh | started streaming
* | anonymous user started streaming
* | anonymous user stopped streaming
josh | stopped streaming

Only 1 user (josh) is showing up in the list of connected users.

Steps to reproduce? No idea. I was using Chrome on Windows and there was a Ctrl+Shift+T that opened a second tab to the same server, but I can't seem to reproduce this problem with anything I try.

thejoshwolfe commented 9 years ago

Uh. I can reproduce the problem. I don't understand what's going on, but opening and closing multiple tabs and hitting the stream button seems to get it sometimes.

andrewrk commented 9 years ago

Can you add the steps to reproduce it? I'll probably fix it alongside #369 and it would be nice to be able to test this and make sure it's still solved.

thejoshwolfe commented 9 years ago

Ok try this:

Does that cause the problem for you?

andrewrk commented 9 years ago

Does that cause the problem for you?

no. it does sound related to that other issue though.