search

andrewrk / groovebasin

Music player server with a web-based user interface.
MIT License
1.9k stars 119 forks source link

ability to specify upload directory #382

Closed saintger closed 9 years ago

saintger commented 10 years ago

I just noticed that uploaded tracks are put in the same directory as the music library directory (/home/user/music). It would be nice if we could specify a specific upload sub-directory in the config file in order not to mess with the original music library (for instance /home/user/music/upload).

andrewrk commented 10 years ago

Will consider this. Also planning to automatically add uploads to an uploads playlist once playlist support is completed.

andrewrk commented 9 years ago

Imported tracks are now added to an Incoming playlist. You can use this to tell which songs were imported, and remove them from the Incoming playlist when you want, or delete them from your library.

If you want only you to be able to manage this playlist, you can remove the "control" permission from guests. If you want more fine grained control over permissions for playlists, follow issue #33.

saintger commented 9 years ago

That would help for sure. But the use case I was looking for was this one: You have a party going and everybody have access to Groove Basin in order to upload/queue their songs from their smartphone. Unfortunately not everybody correctly tag their songs (or have good taste in music), so you end up with your personal library filled with unwanted songs after the party. You can of course manually remove them but it would be much easier to have an optional dedicated upload directory.

andrewrk commented 9 years ago

In this use case you can open the Incoming playlist, select all the songs that were uploaded at the party, and delete them all in one fell swoop.

saintger commented 9 years ago

Ok I get it now: indeed it solves the issue. I'll check if empty directories are also removed or if people cannot overwrite some songs, but I think these are just minor annoyances, so that's not important.

Thanks

andrewrk commented 9 years ago

Empty directories are not presently removed but support for that is planned. See #30

People cannot overwrite songs; the code is carefully coded to avoid import clobbering and race conditions. You will notice that if you upload the same song at the same time, one of them gets a "_1" appended to the file name. It is also planned to detect exact duplicates and avoid importing identical tracks multiple times.

Also, shift+click to select multiple tracks in a playlist is not hooked up yet, see #33 for that.

saintger commented 9 years ago

Perfect, thanks very much !