search

andrewrk / juice

Juice inlines CSS stylesheets into your HTML source.
MIT License
60 stars 13 forks source link

Option preserveMediaQueries also for external css files #10

Closed Spica2 closed 10 years ago

Spica2 commented 10 years ago

Option preserveMediaQueries also for external css files. Is that possible or planned in near future?

andrewrk commented 10 years ago

maybe @jrit has an opinion on this

jrit commented 10 years ago

I've thought about it. There really just needs to be an option to take the CSS from external stylesheets and inject them into <style> as a first step. If that was setup properly I think the existing preserveMediaQueries could stay the way it is.

andrewrk commented 10 years ago

I'm not using this module in production anymore - I'm firmly in the "maintainer" role now. So whoever wants this feature has to make it happen.

Spica2 commented 10 years ago

I have a workflow, that first injects the styles into style-tag. But it would be easier to have it as an option. Especialy when you work with css frameworks.

jrit commented 10 years ago

@Spica2 do you want to try updating juice so it has this option?

Spica2 commented 10 years ago

Are you asking me, if I am gonna do that? Thats far out of my capabilities.

jrit commented 10 years ago

@Spica2 ok, I may do it when I have some free time