search

andrewrk / juice

Juice inlines CSS stylesheets into your HTML source.
MIT License
60 stars 13 forks source link

inlineDocumentWithCb catches errors from callback() #18

Open gig-github opened 10 years ago

gig-github commented 10 years ago

The function inlineDocumentWithCb shouldn't run callback() within the try-statement because 1. it catches everything down the callback chain and 2. then re-runs it in the catch-statement. The callback() should be run after the try-catch and let the errors pass right though Juice.

3rd-Eden commented 9 years ago

Ran in to this issue as well, super annoying >_<