search

andrewrk / libsoundio

C library for cross-platform real-time audio input and output
http://libsound.io/
MIT License
1.92k stars 229 forks source link

Add missing WASAPI macros for resampling #198

Closed Crunkle closed 5 years ago

Crunkle commented 5 years ago

The macros needed to fix #194 are not defined by the MinGW headers (see here).

cgutman commented 5 years ago

Have you tried getting them added to MinGW upstream? I think that's the best approach here, since they are officially documented flags.

Crunkle commented 5 years ago

For sure, I will submit a merge when possible, so feel free to reject this if we're out of scope.

The rationale behind adding this here is based on the fact that the majority of systems will continue using outdated headers for the time being (either from package managers or MXE). It seemed a shame to cut off all older versions and complicate the build process simply due to two macros.

cgutman commented 5 years ago

In that case, I think it's fine to do both, but we should definitely get MinGW fixed so we don't have to carry these defines forever.