search

andrewrk / libsoundio

C library for cross-platform real-time audio input and output
http://libsound.io/
MIT License
1.92k stars 229 forks source link

Fixed memory leak #222

Closed techbech closed 4 years ago

techbech commented 4 years ago

First of all, thanks for this amazing lib. The API looks amazing!

So I just started testing soundio, but I kept getting a visual leak detection. The leak was caused by soundio_connect(soundio);

techbech commented 4 years ago

Maybe I need to put this free's somewhere else. I guess there can be cases this fix doesn't account for, but where I put them now fixed the problem I'm having.

techbech commented 4 years ago

thank you, @wegylexy! :-)

techbech commented 4 years ago

@andrewrk Could we soon merge this fix?

wegylexy commented 4 years ago

@andrewrk Do you also have time to evaluate the other pull requests? Especially those WASAPI ones as the current thing is partially broken on Windows 10 v2004.

andrewrk commented 4 years ago

No I won't be making another release for about 2 years, but then it should pick back up. The biggest problem with pull requests is testing. QA for this software is near impossible, we need actual hardware and half the time I ask people if they tested their code, they say "no, I just guessed this would work".