Closed krumelmonster closed 1 year ago
Hi, thanks for your PR!
Rule of thumbs for CMakeLists.txt: never pollute top-project that include a cmake project with PARENT_SCOPE variables!
PARENT_SCOPE is usually used for custom cmake functions.
Concerning your issue, Cmake know how to manage cross dependencies of a project.
add_subdirectory(libsoundio)
target_link_libraries(${PROJECT_NAME} PRIVATE
libsoundio_shared
)
is enough for CMake to compile your project and link to all necessary libraries (alsa, etc...) to make the project works, avoiding the need of your PR.
Regards!
Setting the LIBSOUNDIO_LIBS to Parent Scope will allow it to be used as a CMake submodule like so: