andrewrk / libsoundio

C library for cross-platform real-time audio input and output
http://libsound.io/
MIT License
1.9k stars 230 forks source link

Hardcodes wasapi GUIDs when compiling as C #258

Closed MasonRemaley closed 2 years ago

MasonRemaley commented 2 years ago

We talked about this privately but for the record: the GUIDs were (mostly) already hardcoded for C++, now they're hardcoded for C too and the missing one was added (got the value off a Windows header file.) This makes it easier to build the wasapi backend, since you don't need to link to the Windows DLL that provides these types.

I have not tested this when building as C++. I'm using a Zig build script to build it and don't know how to tell Zig to force it to build as C++--I don't see any reason this change would've broken the C++ side of the ifdef, but I'll test it out to make sure if you let me know how!

My build script.