search

andrewrk / mpd.js

Connect to a music player daemon server, send commands, emit events.
MIT License
89 stars 18 forks source link

remove artist_disambiguation, artist_name, and album_artist in favor of album_artist_name and artist_name #6

Closed andrewrk closed 11 years ago

andrewrk commented 12 years ago

Me: what's the difference between track.artist_name track.artist_disambiguation and track.album_artist_name? 8:10 PM Josh Wolfe: Disambiguation is for various artists. I don't think album artist was popular enough to be useful, so it can probably go. 8:15 PM Josh Wolfe: The idea was for db soundworks to be the album artist and the root of the tree, even though some tracks have other artists in their tags 8:16 PM Me: we can still have that. here's my plan: album_artist = artist_name; artist_name = artist_disambiguation; delete artist_disambiguation; 8:19 PM Me: but we set artist_name to album_artist if blank 8:19 PM Josh Wolfe: Sure. I'd kinda like to see album artist done right someday. We will eventually edit tags. 8:23 PM Me: it's within our power to do it right, once we take over the music library 8:24 PM Josh Wolfe: So you get the current Various Artists thing that works now, where it puts the artist name in the leaf node. You have a plan to do that without that field? 8:36 PM Me: yeah I just pushed that change. artists have keys now and VariousArtists is a special key that is outside the normal keyspace 8:40 PM

artist - string vs object? string -> because some artists don't have any albums or tracks associated with them. object -> otherwise we'd have to expose the hashing function

andrewrk commented 11 years ago

This project is now only going to do protocol-level stuff, nothing stateful.