search

andrewrk / node-s3-cli

command line utility to go along with node s3 module
MIT License
97 stars 35 forks source link

Defaults to environment variables not in documentation #15

Closed cameronmccord2 closed 9 years ago

cameronmccord2 commented 9 years ago

I spent a bit wondering why it wasn't reading my config file. After looking in the code I found it looks at your environment variables first. I work in multiple aws accounts and my environment variables were set up for a different account than the one I was accessing but all I got was 'Error: http status code 403'. Perhaps the documentation should say it looks to your environment variables first, even if you specify a config file using --config. Thanks!

andrewrk commented 9 years ago

Good point. I think this module should check config first, then env vars.

andrewrk commented 9 years ago

Alright really sorry about that. Now it prioritizes config over env vars, and I published the result as 0.13.0 with a minor bump in case anyone depended on the other behavior.

Thanks for reporting the issue.