getPublicUrl and getPublicUrlHttp are inconsistent

andrewrk / node-s3-client

high level amazon s3 client for node.js

MIT License

1k stars 305 forks source link

Open trufae opened 8 years ago

trufae commented 8 years ago

The spaguetti implementation of those two public functions expose several flaws:

non-https version doesn't honors the bucket location prefix
those helpers should be implemented inside the Client and the uploadFile objects
if the only difference between them is http/https. it seems overkill to provide two functions
bucketLocation can be infered from the Client configuration

trufae commented 8 years ago

See https://github.com/andrewrk/node-s3-client/pull/117 but it's an incomplete change because i'm expecting some feedback on this before going further