search

andrewrk / node-s3-client

high level amazon s3 client for node.js
MIT License
1k stars 305 forks source link

Bump graceful-fs dependency (graceful-fs@2 and @3 support will be removed soon) #122

Open ChALkeR opened 8 years ago

ChALkeR commented 8 years ago

graceful-fs versions lower than v4 reevaluate native fs module source, which is not supported. You should update your graceful-fs dependency to v4 or later.

Tracking issue: https://github.com/nodejs/node/issues/5213.

keshavkaul commented 8 years ago

:+1:

asimo commented 8 years ago

+1 Thanks for the awesome work.

krazik commented 8 years ago

👍

jeroenrinzema commented 8 years ago

+1

ChALkeR commented 8 years ago

Hi.

graceful-fs@2 and @3 support will be removed soon.

s3 is currently #20 in my list of modules that would likely be broken when https://github.com/nodejs/node/pull/6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: https://github.com/nodejs/node/issues/5213.

yachaka commented 8 years ago

+1

yachaka commented 8 years ago

Apparently, this is something that's already been changed in the actual commit. The graceful-fs version is 4.1.4, while it hasn't been changed in the npm package.

A publish from the author should be enough.

Meanwhile, I will be using this git repository as a dependency.