(npm module) Doesn't work on Electron 1.8.2 (culprit: graceful-fs^3.0.11)

andrewrk / node-s3-client

high level amazon s3 client for node.js

MIT License

1k stars 303 forks source link

(npm module) Doesn't work on Electron 1.8.2 (culprit: graceful-fs^3.0.11) #197

Open dbuezas opened 6 years ago

dbuezas commented 6 years ago

This goes away if I manually upgrade graceful-fs. This seems to also break in Node 6 and is actually already corrected in this repo but no new version was published to npm.

imperiumzigna commented 6 years ago

Same error in electron 2.0

gitsome commented 5 years ago

Electron 6 requires Node 12 which has an incompatibility with graceful-fs 3. @electron-forge/publisher-s3 depends on "s3" so it makes that publisher with Electron 6 fail.

gitsome commented 5 years ago

Looks like the graceful-fs version is updated. As stated by @dbuezas, the change is in master but no NPM published version is available with this change. Please publish to NPM.