search

andrewrk / node-s3-client

high level amazon s3 client for node.js
MIT License
1k stars 303 forks source link

ReferenceError: internalBinding is not defined #215

Open bonesoul opened 5 years ago

bonesoul commented 5 years ago

tracked it down to here.

anyone also having the issue?

JohanBengtsson commented 5 years ago

@bonesoul Yes, I think it's due to the dependency to an old version of graceful-js but I'm not 100% sure. I'm investigating it right now.

bonesoul commented 5 years ago

graceful-js uses the natives package i guess.

i think it's the offending one.

https://github.com/nodejs/node/issues/25132

JohanBengtsson commented 5 years ago

@bonesoul I fixed the issue by resolving grafeul-js as one of the comments suggested (we're using yarn) 

"resolutions": {
    "graceful-fs": "4.1.15"
}
bonesoul commented 5 years ago

is there a way to make the resolution fixed with npm?

JohanBengtsson commented 5 years ago

not sure, don't think NPM has it natively but this package seems to give the same functionality https://www.npmjs.com/package/npm-force-resolutions ? I guess you'll need to start using package-lock.json if you don't already @bonesoul

bonesoul commented 5 years ago

i already use package-lock and will give a try to npm force resolutions.