andrewrk / node-s3-client

high level amazon s3 client for node.js
MIT License
1k stars 303 forks source link

don't use this library #229

Closed whatsdis closed 4 years ago

whatsdis commented 4 years ago

someone got offended on the internet because I used the word "shit" to describe this library so I am now removing the work around I posted here that would've saved you a lot of time.

Saving countless hours of wasted effort by warning others about using this library was of no importance. The fact that the word "shit" to describe this library was of more concern to some people. I will never understand why someone would choose to get offended over little things. I will never understand why some people need to shame others in order to feel morally superior. I will never understand why you would come on github out of all places to engage in SJW type of behavior.

The hell with productivity, politics is more important to some developers. It really takes the fun out of contributing on open source. I'm not sure if I want to do this anymore, contributing for years without asking for a dime while some people who work with Fortune 500 companies exploit and won't pay anything themselves, has the audacity to shame and scold others for using a certain English vocabulary to describe abandonware.

Now more naive developers will install this library only to find its shit. Y'all can thank @goldbergyoni and his superior sense of ethics and justice. Don't worry, the author will update this library anyday now, we are all wrong.

Vehmloewff commented 4 years ago

Yeah, https://github.com/auth0/node-s3-client is the way to go.

technicallyty commented 4 years ago

@Vehmloewff i tried using that but i'm getting "can't find module 's3'" error.

Vehmloewff commented 4 years ago

What version of node to you have?

technicallyty commented 4 years ago

Nevermind, turns out the readme on auth0's is incorrect. You have to require like this:

var s3 = require('@auth0/s3')

just forked it and updated it myself. Seems like they're not doing anything with pull requests.

lasergoat commented 4 years ago

My issue is this library depends on an old version of graceful-fs which doesn't work with Node v12.

If you are simply uploading files to s3, consider just using the aws-sdk like this: https://stackabuse.com/uploading-files-to-aws-s3-with-node-js/

goldbergyoni commented 4 years ago

@whatsdis I think that you should be ashamed, this is not the way to treat people who spent precious time on contributing but had to quit. You can't even imaging why this person has to stop actively supporting this, so many circumstances could lead to this. How dare you without paying a dime speaking this way? Yeah, there are more formalized ways to quit, he could put some notice, but calling their volunteering work 'shit' is a shame