search

andrewrk / node-s3-client

high level amazon s3 client for node.js
MIT License
1k stars 305 forks source link

UploadDir should diff headers #90

Open aldendaniels opened 9 years ago

aldendaniels commented 9 years ago

Thanks for this fantastic library! Really enjoying using this.

Issue detailed below.

When...

  1. An object matching a local file already exists in the remote bucket AND
  2. The remote object has different headers than those provided via s3Params

...then s3Client.uploadDir() should update the remote headers, instead of doing a NOOP.

mikefrey commented 9 years ago

Does this happen only when the contents of the local file has not changed?

aldendaniels commented 9 years ago

IDK, but that seems likely to me. In my case, I know that the contents had not changed.