search

andrewrk / node-waveform

simultaneously transcode audio and generate visuals - Node.js module
MIT License
101 stars 19 forks source link

Set correct encoding for stdout #4

Closed kbortnik closed 9 years ago

kbortnik commented 9 years ago

Correct encoding of stdout, so that it doesn't contain a string of gibberish.

andrewrk commented 9 years ago

I think encoding: binary is deprecated. Why isn't this encoding: utf8?

maxBuffer increase to 5MB looks fine.

kbortnik commented 9 years ago

Yes, it seems that binary encoding will be removed from Node. Unfortunately, utf8 does not work, as it just treats stdout as text. utf8 is the default encoding for child_process.execFile.

A Buffer, however, does work.

andrewrk commented 9 years ago

I bumped the major version and then released.