search

andrewrothstein / ansible-miniconda

MIT License
28 stars 26 forks source link

Removed auto-removal of conda curl #3

Closed treuherz closed 7 years ago

treuherz commented 7 years ago

As it is, this role only runs if the user specifies installation of curl, so having the removal of conda curl in by default makes no sense. Plus, if a user has explicitly specified that curl be installed with conda, they probably don't want it removed automatically, conflicts or no. As such, there is no circumstance in which this task is a good idea.

andrewrothstein commented 7 years ago

https://github.com/lsst/lsstsw/issues/40

was why I removed the curl installed with conda

treuherz commented 7 years ago

Right, and I understand why that makes it useful for the Anaconda role, but since Miniconda doesn't install curl without explicitly being told to, the setup you've got means the default behaviour of the role is to fail. It tries to remove a curl that is not there and throws an error.

treuherz commented 7 years ago

Did not mean to hit "close and comment", my bad.

andrewrothstein commented 7 years ago

merged your change. dusted the role off a bit as well and upgraded the miniconda version. published as andrewrothstein.miniconda v1.0.0 on the galaxy.