andrewscaya / mod_simpleemailform

Joomla module: mod_simpleemailform
http://joomla.unlikelysource.org/
GNU General Public License v2.0
3 stars 4 forks source link

Getting error of missing closing DIV #18

Closed thonal closed 7 years ago

thonal commented 7 years ago

Hi,

When I tried to validate a website, it failed on the email form saying it was missing a closing div. After some digging I noticed that the missing closing div could be resolved by adding it to line 1587 of "/modules/mod_simpleemailform/sefv2.modsimpleemailform.php" :

        .......$this->output .= "</table>\n";

        $this->output .= "</form>\n";

# FLS: Added div. error from validator that is was missing!
        $this->output .= "</div>\n";

        if ($this->formTestMode === 'Y') {
            $this->output = htmlspecialchars($thi.....

I don't know if this is a correct 'fix' or a hack to make it work? It does seem that it closes the div opened at line 1529:

        // Present the Email Form.
        $this->output .= !empty($this->formCssClass)
            ? "<div class=\"" . $this->formCssClass . "\">\n"
            : '';

Could you please advise?

Regards,

Thonal

andrewscaya commented 7 years ago

Hello Thonal,

You are absolutely right! The missing 'div' will be added immediately on the develop branch and will be part of the next release scheduled to be published in August 2017.

Many thanks!

Best regards,

Andrew

andrewscaya commented 7 years ago

Bug fix completed - commit #bc977a9.