search

andrewsiefert / sPlotOpenR

R package for working with the sPlotOpen Vegetation Plot Database
Other
5 stars 3 forks source link

Testing package functions #1

Closed fariadamasceno closed 1 year ago

fariadamasceno commented 1 year ago

I tested all the functions implemented so far and commented about the output.

There are two dependency issues with packages TNRS and dggridR, which must be installed for the functions to run.

In addition to that, I pointed out where minor improvements on error messages could be included. If wanted, these messages could be implemented with if checks: if { data != , "Error message" }.

fariadamasceno commented 1 year ago

Hi Andrew,

It is good to know that my comments were useful. The idea with the pull request was to keep this discussion here in github, but you are right, I would probably have done better by asking to be a collaborator into the project and open an issue. Now that I know you think the messages are nice, I can edit the source code and make a new pull request. You could simply reject this one and consider only the next. Is that fine for your?

andrewsiefert commented 1 year ago

Closing this PR and creating Issues to address proposed changes.