andrewsomething / bug2trello

A Chrome extension to add bugs/issues to a Trello board
Other
22 stars 9 forks source link

`undefined (Issue)` card is created when I use version 0.7 #22

Closed shige closed 5 years ago

shige commented 7 years ago

Hi, Thank you for updating the bug2trello chrome extension. But I found the bug.

If I clicked the Add to Trello button, the card is created with title com: #25099 - undefined (Issue). It seems lacking the pull request title.

image

image

Could you fix this bug if you can?

I'm using version 0.7.

image

Thanks!

andrewsomething commented 7 years ago

Thanks for the report. What platform is the bug/issue on?

kongo commented 7 years ago

Encountered the same issue with Bitbucket.

shige commented 7 years ago

@andrewsomething

What platform is the bug/issue on?

the info is below.

image

shige commented 7 years ago

I check-outed the old version 0.6 and I'm using it now.

eoger commented 6 years ago

I just committed a fix (https://github.com/andrewsomething/bug2trello/commit/ae9a8e746c1afe4901c874b7ad1d89c1e0620902) for that issue on master, could you try and see if this resolves the problem for you @bakorer @kongo?

shige commented 6 years ago

@eoger CC: @kongo Thank you for fixing this problem. 👏

I checked on the current master branch ( ae9a8e746c1afe4901c874b7ad1d89c1e0620902 ) , but it seems some errors on chrome developer tools. 👀

Could you check these errors ❓

image

index.js Failed to load resource: net::ERR_FILE_NOT_FOUND
client.js:11 Uncaught ReferenceError: jQuery is not defined
    at client.js:11
eoger commented 6 years ago

I had the same problem, it seems that npm run dev is broken. Run npm run build and load the temporary addon from dist/

shige commented 6 years ago

@eoger Thanks! Which Node.js version should I use?

eoger commented 6 years ago

I think as long as it's recent it's fine. I used node 8 to work on that patch.

shige commented 6 years ago

@eoger It works on GitHub private issue and pull-request. 👏


📝 Tried following

nvm install v8.2.1
npm install
npm run build

Load dist dir via Chrome browser.

eoger commented 6 years ago

Awesome, thank you for testing!

shige commented 5 years ago

It seems fixed on current master https://github.com/andrewsomething/bug2trello/commit/ae9a8e746c1afe4901c874b7ad1d89c1e0620902