search

andrewtavis / wikirepo

Python based Wikidata framework for easy dataframe extraction
BSD 3-Clause "New" or "Revised" License
39 stars 6 forks source link

Remove duplicate condition check #10

Closed kination closed 3 years ago

kination commented 3 years ago

Hello, While reviewing the code, just fix a small duplicated condition check.

Please review πŸ™

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (9fd1728) into main (db4ce47) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files          33       33              
  Lines        1202     1201       -1     
==========================================
- Hits         1069     1068       -1     
  Misses        133      133
Impacted Files Coverage Ξ”
src/wikirepo/data/time_utils.py 97.40% <100.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 10b3b9a...9fd1728. Read the comment docs.

andrewtavis commented 3 years ago

Hi @djKooks, thanks for this! All looks fine to me :) I'll be going through these codes a bit later in the week looking for similar issues, so I appreciate you helping out in this regard!

kination commented 3 years ago

@andrewtavis okay~I'll make some updates if I found something πŸ™