Fix/make the plugin work without custom data dir

andrewthauer / asdf-alias

Version aliases for asdf-vm

MIT License

26 stars 7 forks source link

Fix/make the plugin work without custom data dir #5

Closed delgurth closed 1 year ago

delgurth commented 3 years ago

The pull request (#2) by @jtzero didn't fix the plugin for me, but it contained some improvements I liked. So I continued on his version.

With sourcing "${ASDF_DIR}/lib/utils.bash" you get the asdf_data_dir function, so if this variable is not set (in @jtzero's case) it will contain the proper default.

Also added a functional test and changed the lint check to be the same on macOS and linux.

andrewthauer commented 2 years ago

Wow, @delgurth - I apologize and somehow I missed this PR. #7 was merged which seems to fix part of this, but here are some additional changes here that seem relevant to incorporate. I'm not sure if you time to rebase/update. If not, I can have a look at integrating these changes in the next few days hopefully. Quick glance suggests the actually source change isn't needed since we flipped the execute bit on the command. However, the tests seem relevant :)

andrewthauer commented 1 year ago

@delgurth - I revamped the repo and incorporated most of the changes you had in this PR. Thank you and sorry for delay.