search

andrewthauer / asdf-alias

Version aliases for asdf-vm
MIT License
26 stars 7 forks source link

Added explicit default for ASDF_DATA_DIR environment variable #7

Closed log2 closed 2 years ago

log2 commented 2 years ago

Fix for #6

log2 commented 2 years ago

@andrewthauer , you're right, absolutely! Plugin asdf alias could use library function asdf_data_dir (see https://github.com/asdf-vm/asdf/blob/master/lib/utils.bash#L39. I'll try to use it soon, then resubmit another updated PR.

log2 commented 2 years ago

@andrewthauer , please, have a look at this revised PR: I have switched from a direct reference to environment variable to a call to the asdf's library function asdf_data_dir, as anticipated. Also, in order for all library functions from $ASDF_DIR/lib/utils.bash to be available while sourcing command.bash, I have disabled execute bit on the file. It would be also feasible to have $ASDF_DIR/lib/utils.bash sourced explicitly at the very start of the file. Would you prefer the latter?

andrewthauer commented 2 years ago

@log2 - I confirmed the other day this execute bit flip would be required and also works on my end. Thanks for the change!